Good Friday agreement is commonly seen to have ended what were euphemistically termed the Troubles in Northern Ireland.